Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAT-200 jsr config importing #44
PLAT-200 jsr config importing #44
Changes from 20 commits
626a66d
c001db6
bd07458
2b933c4
f139632
505e1b4
37a94fd
d487ae9
9bdc2f1
0de61d7
24ef18f
397c271
25d69d2
906e216
4b6b71a
3e8d0f4
21afae4
c4d19f3
0fadd38
c7f9e9a
f3de70b
4a37fbe
3cfa3be
c0c2255
22d8054
9512b9a
0befd53
323db1a
4d30fe1
b64b8bc
b82bcb1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldnt this be:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it definitely should be. Done in 9512b9a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker swarm has the concept of jobs. I know I'm mentioned this before, but maybe we should start using them. Then we might not need to remove the service once it's done as it gets marked as completed and it's easier to then see what has executed against the stack. Check the docs here - https://docs.docker.com/engine/reference/commandline/service_create/#running-as-a-job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so I've given this a go. There are a few reasons I don't really like it.
Overall, if it were my choice, I would keep it the way we have it. I think it's simpler and a bit cleaner, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, ok cool. I thought you would be able to specify the mode in the docker compose which would make the change fairly simple. However it seems that isn't possible yet - docker/cli#2907
Seems job is only supported via the CLI, which is annoying.