Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AutoPlay. #443

Merged
merged 8 commits into from
Aug 9, 2024
Merged

Add AutoPlay. #443

merged 8 commits into from
Aug 9, 2024

Conversation

shef3r
Copy link
Contributor

@shef3r shef3r commented Aug 6, 2024

Issue #442

@shef3r
Copy link
Contributor Author

shef3r commented Aug 6, 2024

As mentioned in the issue, with this PR you can run:
ambie:autoplay to open the app and immedately start playing whatever was playing before,
and ambie:autoplay?minimize to open the app, immedately start playing whatever was playing before, and minimize the app.
I also have an idea to add a ?mini argument there to open Ambie Mini. What do you think?

@shef3r
Copy link
Contributor Author

shef3r commented Aug 6, 2024

I also added an Ambie Mini toggle but for some reason when AMini opens there's no play/pause button? is that intentional?
image

@dpaulino
Copy link
Contributor

dpaulino commented Aug 9, 2024

I also added an Ambie Mini toggle but for some reason when AMini opens there's no play/pause button? is that intentional? image

I talked about this in one of the review comments. We should remove the ambie mini-related code since ambie mini doesn't support this scenario right now

src/AmbientSounds.Uwp/App.xaml.cs Outdated Show resolved Hide resolved
src/AmbientSounds.Uwp/App.xaml.cs Outdated Show resolved Hide resolved
src/AmbientSounds.Uwp/App.xaml.cs Outdated Show resolved Hide resolved
src/AmbientSounds.Uwp/App.xaml.cs Outdated Show resolved Hide resolved
src/AmbientSounds.Uwp/Services/ProtocolLaunchController.cs Outdated Show resolved Hide resolved
@dpaulino dpaulino merged commit b5f61a0 into jenius-apps:main Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants