Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update plugins #513

Merged
merged 1 commit into from
Jun 16, 2022
Merged

chore(deps): update plugins #513

merged 1 commit into from
Jun 16, 2022

Conversation

updatecli-gha-in-jenkins-infra-org[bot]
Copy link
Contributor

Changes:

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it deletes comments :'(

@lemeurherve
Copy link
Member

What deletes which comments?

@dduportal
Copy link
Contributor

What deletes which comments?

Sorry, typed quickly to block it asap.

"The jenkins-plugins-cli command removed the comments when generating the new plugins.txt file"

@lemeurherve
Copy link
Member

lemeurherve commented Jun 14, 2022

The thing is, it doesn't delete them, it regenerate a new file.
It doesn't look easy to fix, maybe a diff, then keep & "merge" only the diff lines not starting by a #?

@dduportal
Copy link
Contributor

The thing is, it doesn't delete them, it regenerate a new file. It doesn't look easy to fix, maybe a diff, then keep & "merge" only the diff lines not starting by a #?

I don't know the codebase so not sure (for instance: is a comment parsed and associated to a line, or just ignored)?
There might be the solution to use YAML format maybe?
Or to ask jenkins-plugin-cli to write the plugin.txt file itself

Opened jenkinsci/plugin-installation-manager-tool#446

@dduportal dduportal merged commit bb764ff into main Jun 16, 2022
@dduportal dduportal deleted the update-plugins branch June 16, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants