Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jenkinsio chart issue: could not find expected ':' #658

Closed
lemeurherve opened this issue Sep 6, 2023 · 0 comments · Fixed by #808
Closed

Fix jenkinsio chart issue: could not find expected ':' #658

lemeurherve opened this issue Sep 6, 2023 · 0 comments · Fixed by #808
Assignees
@dduportal
Labels
good first issue Good for newcomers jenkinsio

Comments

@lemeurherve
Copy link
Member

helm template jenkinsio output:

Error: YAML parse error on jenkinsio/templates/deployment.yaml: error converting YAML to JSON: yaml: line 60: could not find expected ':'

Unit tests should be added, doc: https://github.com/helm-unittest/helm-unittest/blob/main/DOCUMENT.md
@dduportal dduportal self-assigned this Sep 28, 2023
dduportal added a commit to dduportal/helm-charts that referenced this issue Sep 28, 2023
@dduportal
fix(jenkinsio) ensure default values are valid. Closes jenkins-infra#658
e5dbb65 
.

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal mentioned this issue Sep 28, 2023
Merged
dduportal added a commit that referenced this issue Sep 28, 2023
@dduportal
Merge pull request #808 from dduportal/fix/jenkinsio/fix-default-values
ca4f734 
fix(jenkinsio) ensure default values are valid. Closes #658.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dduportal dduportal

Labels
good first issue Good for newcomers jenkinsio
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(jenkinsio) ensure default values are valid. Closes #658. dduportal/helm-charts
2 participants
@dduportal @lemeurherve