feat(acp) enable async IO except for file larger than 10Mb #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to jenkins-infra/helpdesk#3481
Added some documentations in comment to help justifying the set of choices:
aiois now enabled, allowing unblocking "short lived" connections while bigger files are being read. It's required for enablingdirectio(see below).directiois set up to ensure bigger file are not read though the OS file caching. It's interesting for big artifacts which are clearly blocking calls.sendfile_max_chunkis set to its default value2m(as per http://nginx.org/en/docs/http/ngx_http_core_module.html#sendfile_max_chunk)tcp_nodelayis enabled to ensure that packets not "fully filled" (as pertcp_nopush) are sent without delay (unblocking more connections)