Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!(rsyncd) harden container execution with image 1.0.0 #665

Merged
merged 3 commits into from
Sep 7, 2023
Merged

feat!(rsyncd) harden container execution with image 1.0.0 #665

merged 3 commits into from
Sep 7, 2023

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Sep 6, 2023 •
edited
Loading

BREAKING CHANGE: former values need to be adapted

  • Supports the new image 1.0.0
    • Default user nobody
    • New default configuration scheme
    • Changed motd
  • Fixed pod level attributes (tolerations, nodeselectors, security context, etc.)

@dduportal dduportal marked this pull request as draft September 6, 2023 18:12
@dduportal dduportal force-pushed the feat/rsyncd/hardening branch from 16e1d60 to 63b1f87 Compare September 6, 2023 18:17
@dduportal dduportal marked this pull request as ready for review September 6, 2023 18:18
lemeurherve
lemeurherve reviewed Sep 6, 2023
View reviewed changes
Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some comments and a possible issue to fix, maybe.

charts/rsyncd/templates/deployment.yaml Show resolved Hide resolved
charts/rsyncd/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/rsyncd/templates/deployment.yaml Show resolved Hide resolved
charts/rsyncd/tests/custom_values_test.yaml Show resolved Hide resolved
lemeurherve
lemeurherve reviewed Sep 7, 2023
View reviewed changes
charts/rsyncd/tests/defaults_test.yaml Outdated Show resolved Hide resolved
charts/rsyncd/tests/defaults_test.yaml Outdated Show resolved Hide resolved
@dduportal
Copy link
Contributor Author

The updatecli check error is the same as the main branch: unrelated to this PR as I'm not changing updatecli yet (despite the 1.0.0 tag)

lemeurherve
lemeurherve previously approved these changes Sep 7, 2023
View reviewed changes
@dduportal dduportal marked this pull request as draft September 7, 2023 15:05
@dduportal
Copy link
Contributor Author

Putting back to draft until @lemeurherve published his patch on the 0.x line to unblokc him (and until updatecli is fixed)

@dduportal dduportal force-pushed the feat/rsyncd/hardening branch from 42081e3 to 78c9136 Compare September 7, 2023 15:37
@dduportal dduportal marked this pull request as ready for review September 7, 2023 15:37
@dduportal
feat!(rsyncd) harden container execution with image 1.0.0
ba44925 
BREAKING CHANGE: former values need to be adapted

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal force-pushed the feat/rsyncd/hardening branch from 78c9136 to ba44925 Compare September 7, 2023 15:49
@dduportal
Copy link
Contributor Author

Ready to roll

@dduportal dduportal enabled auto-merge September 7, 2023 16:48
@dduportal dduportal merged commit fde8273 into jenkins-infra:main Sep 7, 2023
2 checks passed
@dduportal dduportal deleted the feat/rsyncd/hardening branch September 7, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemeurherve lemeurherve lemeurherve approved these changes

@timja timja Awaiting requested review from timja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dduportal @lemeurherve