Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-site) bump Docker image to switch JDK8 to Temurin 1.8.0_382 (and support of cgroups v2) #855

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Oct 11, 2023

Related to jenkins-infra/helpdesk#3774, this PR bumps the container image to a new version with a JDK Temurin version 1.8.0_382.

The goal is to only deploy the JDK change to support cgroups v2 in production.

We did a quick test on a Docker Desktop macOS machine (which uses cgroupsv2 in the LinuxVM) with success:

  • The Docker Desktop VM is set up with 16Gb of memory
  • The default heap size is 25% of what is perceived by the JVM as "the amount of memory available to use"

Before (current production image) states ~4Gb of Heap despite the specified memory limit at 1G:

$ docker run --entrypoint=bash --platform=linux/amd64 --memory=1G jenkinsciinfra/plugin-site-api:294-5389ef -c 'java -XX:+PrintFlagsFinal -version | grep HeapSize'
openjdk version "1.8.0_322"
OpenJDK Runtime Environment (build 1.8.0_322-b06)
OpenJDK 64-Bit Server VM (build 25.322-b06, mixed mode)
    uintx ErgoHeapSizeLimit                         = 0                                   {product}
    uintx HeapSizePerGCThread                       = 87241520                            {product}
    uintx InitialHeapSize                          := 262144000                           {product}
    uintx LargePageHeapSizeThreshold                = 134217728                           {product}
    uintx MaxHeapSize                              := 4192206848                          {product}

After (new image with new Temurin JDK8) shows ~250 Mb of heap size ✅

$ docker run --entrypoint=bash --platform=linux/amd64 --memory=1G jenkinsciinfra/plugin-site-api:295-d7103b -c 'java -XX:+PrintFlagsFinal -version | grep HeapSize'
openjdk version "1.8.0_382"
OpenJDK Runtime Environment (Temurin)(build 1.8.0_382-b05)
OpenJDK 64-Bit Server VM (Temurin)(build 25.382-b05, mixed mode)
    uintx ErgoHeapSizeLimit                         = 0                                   {product}
    uintx HeapSizePerGCThread                       = 87241520                            {product}
    uintx InitialHeapSize                          := 16777216                            {product}
    uintx LargePageHeapSizeThreshold                = 134217728                           {product}
    uintx MaxHeapSize                              := 268435456                           {product}

@dduportal dduportal changed the title Update values.yaml fix(plugin-site) bump Docker image to switch JDK8 to Temurin 1.8.0_382 (and support of cgroups v2) Oct 11, 2023
@dduportal dduportal marked this pull request as ready for review October 11, 2023 13:33
Copy link
Contributor

@smerle33 smerle33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dduportal dduportal added the bug Something isn't working label Oct 11, 2023
@dduportal dduportal merged commit 3d5a3bf into main Oct 11, 2023
2 checks passed
@dduportal dduportal deleted the helpdesk-3774 branch October 11, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants