Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updatecli: Use separated pipelines + organization scanning for all updatecli processes in jenkins-infra #2778

Open
dduportal opened this issue Feb 10, 2022 · 16 comments

Comments

@dduportal
Copy link
Contributor

dduportal commented Feb 10, 2022

  • No more GitHub actions for updatecli (less configuration spread)
  • Updatecli pipeline triggers can be controlled separately from repository own pipelines
    • Simplifies repository own pipelines (less conditions)
    • Allow to fine tune updatecli frequency: weekly, daily, etc.
    • repository own pipelines would be completely separated from the "chore" tasks of updatecli
  • Centralized credentials in infra.ci.jenkins.io (which is private)

Convention Proposal:

  • Use a Jenkinsfile_updatecli a pipeline marker
  • Define a new GH organization scanning on infra.ci.jenkins.io that will check ALL of jenkins-infra and will check for these updatecli processes
  • Write down a documentation of this in jenkins-infra/documentation

Current progress: #2778 (comment)

@dduportal
Copy link
Contributor Author

Blocked by #2834 (because of involved credentials)

@dduportal dduportal added this to the infra-team-sync-next milestone May 2, 2022
lemeurherve pushed a commit to lemeurherve/kubernetes-management that referenced this issue Sep 2, 2022
lemeurherve added a commit to jenkins-infra/kubernetes-management that referenced this issue Sep 12, 2022
* feat: separate updatecli to its own pipeline

Ref: jenkins-infra/helpdesk#2778

* add updatecli job for kubernetes-management on infra.ci

* remove redundant 'Management'

* clean Jenkinsfile_updatecli

* remove unused do token credential for kubernetes-management-updatecli

* update updatecli manifest

* set a top folder with one children instead for now until we adapt the job-dsl chart for a 'organization-scanning' kind

Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
lemeurherve added a commit to jenkins-infra/kubernetes-management that referenced this issue Sep 12, 2022
* feat: separate updatecli to its own pipeline

Ref: jenkins-infra/helpdesk#2778

* add updatecli job for kubernetes-management on infra.ci

* remove redundant 'Management'

* clean Jenkinsfile_updatecli

* remove unused do token credential for kubernetes-management-updatecli

* update updatecli manifest

* set a top folder with one children instead for now until we adapt the job-dsl chart for a 'organization-scanning' kind

* cleanup: remove helmfile image in Jenkinsfile_updatecli
As it's already defined in the 'updatecli' function of the shared pipeline library

* chore: better job description

* fix: quote

Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal
Copy link
Contributor Author

Status:

  • PoC nice on kubernetes-management

Next step:

  • As it's per-repo basis, we have to implement GH org. scanning (wip on helm chart)
  • Slightly minor issue: the 2 jobs have the same GH check status. How to change that?

lemeurherve added a commit to lemeurherve/kubernetes-management that referenced this issue Sep 23, 2022
…2817)

* feat: separate updatecli to its own pipeline

Ref: jenkins-infra/helpdesk#2778

* add updatecli job for kubernetes-management on infra.ci

* remove redundant 'Management'

* clean Jenkinsfile_updatecli

* remove unused do token credential for kubernetes-management-updatecli

* update updatecli manifest

* set a top folder with one children instead for now until we adapt the job-dsl chart for a 'organization-scanning' kind

Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
lemeurherve added a commit to lemeurherve/kubernetes-management that referenced this issue Sep 23, 2022
* feat: separate updatecli to its own pipeline

Ref: jenkins-infra/helpdesk#2778

* add updatecli job for kubernetes-management on infra.ci

* remove redundant 'Management'

* clean Jenkinsfile_updatecli

* remove unused do token credential for kubernetes-management-updatecli

* update updatecli manifest

* set a top folder with one children instead for now until we adapt the job-dsl chart for a 'organization-scanning' kind

* cleanup: remove helmfile image in Jenkinsfile_updatecli
As it's already defined in the 'updatecli' function of the shared pipeline library

* chore: better job description

* fix: quote

Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
@lemeurherve lemeurherve removed this from the infra-team-sync-next milestone Feb 9, 2024
@lemeurherve
Copy link
Member

While they were opened, I updated my PRs to use https://github.com/apps/jenkins-infra-updatecli instead of https://github.com/jenkins-infra-bot in updatecli values. (No more co-authored commits with both updatecli GitHub app and jenkins-infra-bot GitHub bot account)

@dduportal
Copy link
Contributor Author

Update:

  • https://github.com/jenkins-infra/azure-net done
  • For all terraform, we are having issues regarding the pipeline con trigger not updated on azure or azure net. Worth checking the pipeline library for terraform: it was recommend NOT to set up pipeline triggers in the library (but per Jenkins file instead)
  • All GHA > Jenkins changes won't be done as it requires more discussions.

Next steps: all terraform jobs

@dduportal
Copy link
Contributor Author

Applied jenkins-infra/digitalocean#204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants