Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI screenshots in Pipeline documentation #7526 #7653

Merged

Conversation

ShrushtiDesai
Copy link
Contributor

@ShrushtiDesai ShrushtiDesai commented Nov 1, 2024

This PR addresses issue #7526.

I have updated the screenshots for the pages under the Pipeline section of the documentation. Additionally, I revised the alt text for the screenshots and made necessary adjustments to the associated text in the documentation where applicable.

I have also incorporated the suggestions from the previous pull request:

  • Navigate to Manage Jenkins » System » Global Trusted Pipeline Libraries to configure multiple libraries as needed.
  • Next, select or add new Credentials – entering our GitHub username and using the access token as the password.
    Based on your feedback, I’ve committed the text updates and updated the screenshots to align with the naming convention, replacing "master" with "main" where applicable.

On the "Pipeline as Code" page, I also noticed that the Scan Organization process for CloudBeersInc displays three repositories, two of which still reference the "master" branch, as well as the PR demo image where the "master" branch is shown. I have updated these references as well, along with their alt text for accessibility.

I apologize for the inconvenience caused by my mistakes during the force push. Thank you for your patience, and please let me know if further adjustments are needed.

Copy link
Contributor

@kmartens27 kmartens27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look really good, thanks very much for all the work @ShrushtiDesai

I've provided a few suggestions regarding the plugin macro usage and some punctuation, but everything else looks fantastic. Thank you as well for providing good alt text for the images. I'm approving, pending the changes suggested.

content/doc/book/pipeline/docker.adoc Outdated Show resolved Hide resolved
content/doc/book/pipeline/docker.adoc Outdated Show resolved Hide resolved
content/doc/book/pipeline/pipeline-as-code.adoc Outdated Show resolved Hide resolved
content/doc/book/pipeline/shared-libraries.adoc Outdated Show resolved Hide resolved
ShrushtiDesai and others added 9 commits November 6, 2024 01:00
…ation, pipeline config page, build now, console output, pipeline syntax, snippet generator. Also associated text are updated.
…tart from stage. Blue ocean image's alt text updated.
…source, branch source configuration, branch indexing. new item image alt text updated and associated text updated.
…nfig global pipeline library, modern scm, legacy scm. Associated text updated and in screenshots branch name changed to main.
… replay sidebar, replay script modified. Associated text updated.
…der icon, organization folder creation, repository resource config, repositories progress builds, organization repositories, PR demo repository branches, stage concurrency, pipeline workflow, fingerprint. Associated text updated and also 'Credentials' line updated.
plugin:docker-workflow[*Docker Pipeline*]
plugin:custom-folder-icon[*Custom Folder Icon*]

Co-authored-by: Kevin Martens <99040580+kmartens27@users.noreply.github.com>
Co-authored-by: Kevin Martens <99040580+kmartens27@users.noreply.github.com>
Copy link
Contributor

@kmartens27 kmartens27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much @ShrushtiDesai for all of the updates and work to get this updated!

@kmartens27 kmartens27 merged commit 2e8f892 into jenkins-infra:master Nov 5, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants