-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog for 2.54 with new CLI and Java 8 requirement #815
Conversation
Also clean up some older entries: - Use <code> rather than <tt> for code/file paths/similar - Don't use any special highlighting for version numbers
references: | ||
- issue: 42744 | ||
# pull: 2826 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deliberate: On top level, we only show issue if both exist, but in references
, we show everything. Keep top-level behavior but document the pull request number.
issue: 42934 | ||
pull: 2816 | ||
- issue: 42934 | ||
# pull: 2816 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above.
content/_data/changelogs/weekly.yml
Outdated
- issue: 42709 | ||
- pull: 2802 | ||
# - url: TODO | ||
# title: announcement blog post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prepared for blog post I expect will be published in the next few days.
- issue: 41745 | ||
- pull: 2795 | ||
# - url: TODO | ||
# title: announcement blog post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prepared for blog post I expect will be published in the next few days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also provide a link to CLI documentation, which will be updated by #802
@daniel-beck It also worth mentioning this:
It was displaying only the issue IIRC. Maybe it was changed. |
@daniel-beck in the end, it's more for you and Oleg, but why not standardize on something shorter like "classical" backtick `, as anyway this is yaml and needs some level of processing? Just an idea obviously, again, your call and Oleg's. |
Just check the current changelog, the problem is that it shows two groups of parentheses, one for top-level issue/pull, one for references. |
content/_data/changelogs/weekly.yml
Outdated
- type: bug | ||
message: > | ||
Introduce status indicator for skipped download job. | ||
# TODO adequately explain what this does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO it's enough
content/_data/changelogs/weekly.yml
Outdated
pull: 2705 | ||
- type: bug | ||
message: > | ||
Properly handle saving system configuration when disabling all administrative monitors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"all" and "all excepting one"
# title: announcement blog post | ||
- type: rfe | ||
message: > | ||
Disable SSH server by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SSH Server port
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's a relevant difference.
Also clean up some older entries:
<code>
rather than<tt>
for code/file paths/similarissue
andpull
andreferences
, the presentation is currently weird.@oleg-nenashev Could we standardize on the above for future changelog entries?