Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 2.54 with new CLI and Java 8 requirement #815

Merged
merged 5 commits into from
Apr 9, 2017

Conversation

daniel-beck
Copy link
Contributor

Also clean up some older entries:

  • Use <code> rather than <tt> for code/file paths/similar
  • Don't use any special highlighting for version numbers
  • Don't use both top-level issue and pull and references, the presentation is currently weird.

screen shot


@oleg-nenashev Could we standardize on the above for future changelog entries?

Also clean up some older entries:

- Use <code> rather than <tt> for code/file paths/similar
- Don't use any special highlighting for version numbers
references:
- issue: 42744
# pull: 2826
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deliberate: On top level, we only show issue if both exist, but in references, we show everything. Keep top-level behavior but document the pull request number.

issue: 42934
pull: 2816
- issue: 42934
# pull: 2816
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

- issue: 42709
- pull: 2802
# - url: TODO
# title: announcement blog post
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prepared for blog post I expect will be published in the next few days.

- issue: 41745
- pull: 2795
# - url: TODO
# title: announcement blog post
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prepared for blog post I expect will be published in the next few days.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also provide a link to CLI documentation, which will be updated by #802

@oleg-nenashev
Copy link
Contributor

@daniel-beck It also worth mentioning this:

  • JENKINS-33595 - SSHD 1.11: Disable SSHD port by default on new installations.

Don't use both top-level issue and pull and references, the presentation is currently weird.

It was displaying only the issue IIRC. Maybe it was changed.

@orrc
Copy link
Member

orrc commented Apr 8, 2017

Would it be possible to make the Java 8 item a bit bolder (like with 1.612), or shown as a callout, as with 2.0?

@batmat
Copy link
Contributor

batmat commented Apr 8, 2017

Use <code> rather than <tt> for code/file paths/similar

@daniel-beck in the end, it's more for you and Oleg, but why not standardize on something shorter like "classical" backtick `, as anyway this is yaml and needs some level of processing?

Just an idea obviously, again, your call and Oleg's.

@daniel-beck
Copy link
Contributor Author

@orrc Done

@batmat Beyond my abilities to do in Awestruct, unfortunately.

@daniel-beck
Copy link
Contributor Author

@oleg-nenashev

It was displaying only the issue IIRC. Maybe it was changed.

Just check the current changelog, the problem is that it shows two groups of parentheses, one for top-level issue/pull, one for references.

- type: bug
message: >
Introduce status indicator for skipped download job.
# TODO adequately explain what this does
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO it's enough

pull: 2705
- type: bug
message: >
Properly handle saving system configuration when disabling all administrative monitors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"all" and "all excepting one"

# title: announcement blog post
- type: rfe
message: >
Disable SSH server by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSH Server port

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's a relevant difference.

@daniel-beck daniel-beck merged commit 30f8d71 into jenkins-infra:master Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants