Add a new infra.prepareToPublishIncrementals() method to optimize the resource usage
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffret-b
approved these changes
Aug 28, 2019
| */ | ||
| void prepareToPublishIncrementals() { | ||
| // MINSTALL-126 would make this easier by letting us publish to a different directory to begin with: | ||
| String m2repo = sh script: 'mvn -Dset.changelist -Dexpression=settings.localRepository -q -DforceStdout help:evaluate', returnStdout: true |
There was a problem hiding this comment.
Why not infra.runMaven() ? The mirror will not be used for plugin download
There was a problem hiding this comment.
You cannot use runMaven for this purpose: returnStdout.
This could call retrieveMavenSettingsFile again (with a sufficiently distinctive path), though it seems like overkill. This would typically be run after the main build, so the only additional plugins that might be downloaded would be maven-help-plugin I think.
| /** | ||
| * When appropriate, publish artifacts from the current build to the Incrementals repository. | ||
| * Call at the end of the build, outside any node, when #prepareToPublishIncrementals may have been called previously. |
There was a problem hiding this comment.
Is it a strong requirement?
There was a problem hiding this comment.
What? To call outside node? Well nothing will break if you call it inside node, but you will be wasting executor minutes.
oleg-nenashev
approved these changes
Aug 31, 2019
oleg-nenashev
changed the title
infra.prepareToPublishIncrementals() method to optimize the resource use
oleg-nenashev
changed the title
infra.prepareToPublishIncrementals() method to optimize the resource useinfra.prepareToPublishIncrementals() method to optimize the resource usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in jenkinsci/jenkins-test-harness#162. @oleg-nenashev @rtyler