Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip test result collection if tests are skipped #126

Merged
merged 1 commit into from
Dec 27, 2019
Merged

Skip test result collection if tests are skipped #126

merged 1 commit into from
Dec 27, 2019

Conversation

darxriggs
Copy link
Contributor

It was missed in commit 14ca5fe.

@darxriggs
Copy link
Contributor Author

I will also create another pull request to add tests for buildPluginWithGradle when this one is merged.

@oleg-nenashev oleg-nenashev merged commit 3965c16 into jenkins-infra:master Dec 27, 2019
@darxriggs darxriggs deleted the skip-test-result-collection branch December 27, 2019 14:47
@darxriggs
Copy link
Contributor Author

@oleg-nenashev could you already release this and use it on ci.jenkins.io?

I am asking because while migrating Gradle-based plugins from buildPlugin to buildPluginWithGradle, it shows that some do not have tests at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darxriggs @oleg-nenashev