Fix default value handling for archiveArtifacts and installArtifacts Boolean properties in customWARPackager()
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the elvis operator should be avoided for Booleans. The value of `installArtifacts` has always been set to `true`, irrespective of the value configured in the YAML file.
darxriggs
referenced
this pull request
Dec 30, 2019
oleg-nenashev
approved these changes
Dec 30, 2019
oleg-nenashev
changed the title
archiveArtifacts and installArtifacts Boolean properties
oleg-nenashev
changed the title
archiveArtifacts and installArtifacts Boolean propertiesarchiveArtifacts and installArtifacts Boolean properties in customWARPackager()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the elvis operator should be avoided for Booleans.
The value of
installArtifactshas always been set totrue, irrespective of the value configured in the YAML file.