Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA-2379] - Fix Incrementals publishing by Change Azure componentto jenkins-community-functions #133

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

jglick
Copy link
Contributor

@jglick jglick commented Jan 14, 2020

Not sure if this will solve INFRA-2379 but it can hardly make it more broken. @olblak @rtyler

$ curl -i -H 'Content-Type: application/json' -d '{"build_url":"http://whatever/"}' 'https://jenkins-incrementals.azurewebsites.net/api/incrementals-publisher?clientId=default&code=whatever'
HTTP/1.1 401 Unauthorized
Request-Context: appId=
Date: Tue, 14 Jan 2020 15:41:25 GMT
Content-Length: 0

$ curl -i -H 'Content-Type: application/json' -d '{"build_url":"http://whatever/"}' 'https://jenkins-community-functions.azurewebsites.net/api/incrementals-publisher?clientId=default&code=whatever'
HTTP/1.1 400 Bad Request
Cache-Control: no-cache
Pragma: no-cache
Content-Length: 103
Content-Type: application/json; charset=utf-8
Expires: -1
Server: Microsoft-IIS/10.0
X-Powered-By: ASP.NET
Date: Tue, 14 Jan 2020 15:41:39 GMT

{"Message":"The 'code' query parameter provided in the HTTP request did not match the expected value."}

@jglick jglick requested a review from a team January 14, 2020 15:39
@jglick
Copy link
Contributor Author

jglick commented Jan 14, 2020

Or @oleg-nenashev or whoever would feel comfortable merging this as an experiment (and being ready to back it out in an emergency, in case it somehow causes a build failure and not merely failure to deploy).

Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can hardly make it more broken

Famous last words.

I will be available till 11PM UTC to rollback it if needed

@oleg-nenashev oleg-nenashev merged commit db1e87e into jenkins-infra:master Jan 14, 2020
@jglick jglick deleted the patch-2 branch January 14, 2020 20:17
@jglick
Copy link
Contributor Author

jglick commented Jan 14, 2020

No, it does not work, though it makes nothing worse:

The 'code' query parameter provided in the HTTP request did not match the expected value.

Maybe the incrementals-publisher-token needs to be updated too.

@oleg-nenashev oleg-nenashev changed the title [INFRA-2379] Change Azure component [INFRA-2379] Change Azure component for publishIncrementals() to https://jenkins-community-functions.azurewebsites.net Jan 17, 2020
@oleg-nenashev oleg-nenashev changed the title [INFRA-2379] Change Azure component for publishIncrementals() to https://jenkins-community-functions.azurewebsites.net [INFRA-2379] Change Azure component for publishIncrementals() to jenkins-community-functions Jan 17, 2020
@oleg-nenashev oleg-nenashev changed the title [INFRA-2379] Change Azure component for publishIncrementals() to jenkins-community-functions [INFRA-2379] - Fix Incrementals publishing by Change Azure componentto jenkins-community-functions Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants