Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: move duplicated test code to a super class #136

Merged
merged 13 commits into from
May 25, 2020
Merged

Refactor: move duplicated test code to a super class #136

merged 13 commits into from
May 25, 2020

Conversation

v1v
Copy link
Contributor

@v1v v1v commented Feb 20, 2020 •
edited
Loading

@v1v v1v marked this pull request as ready for review February 20, 2020 18:43
@v1v v1v requested a review from a team February 20, 2020 18:43
@v1v
Copy link
Contributor Author

v1v commented Apr 13, 2020

I just updated the repo with the master branch, any feedback?

@v1v
Copy link
Contributor Author

v1v commented Apr 26, 2020

@jenkins-infra/ci-maintainers , any feedback?

oleg-nenashev
oleg-nenashev approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed it in my infinite PRs queue :(
Looks good after a quick review, just need to fix the CI

@oleg-nenashev oleg-nenashev merged commit 0c78670 into jenkins-infra:master May 25, 2020
@v1v v1v deleted the feature/refactor-common branch June 12, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v1v @oleg-nenashev