Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move src/test/ to test/ #138

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Move src/test/ to test/ #138

merged 1 commit into from
Mar 12, 2020

Conversation

dwnusbaum
Copy link
Contributor

Shared libraries shouldn't put test code underneath src.

CC @oleg-nenashev

@dwnusbaum dwnusbaum requested a review from a team March 12, 2020 16:19
oleg-nenashev
oleg-nenashev approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to merge this change right away, because it aligns the Pipeline Library with the documented best practices

@oleg-nenashev oleg-nenashev merged commit c7acbe5 into jenkins-infra:master Mar 12, 2020
@dwnusbaum dwnusbaum deleted the mv-src-test branch March 12, 2020 16:27
@dwnusbaum dwnusbaum mentioned this pull request Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwnusbaum @oleg-nenashev