buildDockerImage() #147
Merged
buildDockerImage() #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@halkeye Could you please merge it with the master? |
|
yay green again |
timja
reviewed
May 26, 2020
timja
previously approved these changes
May 26, 2020
| stage("Build") { | ||
| steps { | ||
| script { | ||
| GIT_COMMIT_REV = sh(returnStdout: true, script: "git log -n 1 --pretty=format:'%h'").trim() |
There was a problem hiding this comment.
isn't this already added by declarative pipeline or is it too long?
There was a problem hiding this comment.
/shrug
is it? its not super googleable
| stage("Deploy master as latest") { | ||
| when { branch "master" } | ||
| steps { | ||
| sh "docker tag ${config.registry}${imageName} ${config.registry}${imageName}:master" |
There was a problem hiding this comment.
is a master tag needed as well as latest?
There was a problem hiding this comment.
I don't know, latest really could be anything, while master is master branch
But yea, i donno, i mostly copy and pasted it from my own shared pipeline which had this, but I'm not sure i ever used anything other than latest and tag
Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>
I did no such thing, I guess every new commit dismisses it? |
timja
approved these changes
May 26, 2020
oleg-nenashev
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new pipeline (based on my own shared lib)
Also upgraded the base unit test framework so it can test declarative pipelines, and renamed checkout to checkoutSCM so the testing framework doesn't conflict with it.