Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves dependency bot probe result recognition #459

Merged

Conversation

alecharp
Copy link
Collaborator

@alecharp alecharp commented Feb 7, 2024

Description

Resolves #454.

This was introduced in #437 and it shows the limitations of the string recognition used in the project between probe results and scoring implementations.

Testing done

Fix the tests to use the correct probe result message content and fixed the code based on the test execution.

Submitter checklist

This was introduced in jenkins-infra#437 and it shows the limitations of the string recognition used
in the project between probe results and scoring implementations.
@alecharp alecharp added the bug Something isn't working label Feb 7, 2024
@alecharp alecharp merged commit a289d84 into jenkins-infra:main Feb 7, 2024
18 checks passed
@alecharp alecharp deleted the fix/dependency-bot-incorrect-detection branch February 7, 2024 11:15
@alecharp alecharp restored the fix/dependency-bot-incorrect-detection branch February 7, 2024 11:15
@alecharp alecharp deleted the fix/dependency-bot-incorrect-detection branch February 7, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to achieve 100% health score for jenkins plugin
1 participant