Setup spotless #477
Merged
Setup spotless #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecharp
force-pushed
the
feature/setup-spotless
branch
from
289cc8d
to
d8efc67
Compare
|
The changes look good to me. In the PR description you have mentioned that checkstyle ignored the missing license header. Would spotless solve the issue? |
Jagrutiti
approved these changes
Mar 6, 2024
alecharp
force-pushed
the
feature/setup-spotless
branch
from
d8efc67
to
9e97a7c
Compare
|
That's what this PR is for. |
Let's checkstyle not fail because of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checkstyle on its own did not notice the missing license header on a couple of classes.
Testing done
There is no code modification.
Submitter checklist