Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Maven options interpretation during CI build #496

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

lemeurherve
Copy link
Member

Description

This PR fixes tags publication by actually passing OPTS as env var to maven script.

Fixup of:

Testing done

Successful replay of the 3.8.0 tag on infra;ci.jenkins.io

Submitter checklist

@lemeurherve lemeurherve added the chore Related to the project configuration label Mar 23, 2024
@lemeurherve lemeurherve enabled auto-merge (squash) March 23, 2024 19:52
@alecharp
Copy link
Collaborator

I'm surprise this is necessary as the previous release replay (3.7.1) was successful..

@lemeurherve
Copy link
Member Author

I'm surprise this is necessary as the previous release replay (3.7.1) was successful..

The replay wasn't exactly the same (my mistake, sorry), it was still using """ instead of ''' thus $OPTS was interpolated by Groovy.

Using ''' is safer.

@lemeurherve lemeurherve merged commit ac8a1cd into jenkins-infra:main Mar 25, 2024
19 checks passed
@alecharp alecharp changed the title fixup: pass OPTS as env var Fix Maven options interpretation during CI build Mar 25, 2024
@lemeurherve lemeurherve deleted the fixup-publication branch March 25, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to the project configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants