Merge pull request #134 from jonesbusy/bugfix/jgit-not-closed

Fix jgit not closed during clone
jenkins-infra · Jul 30, 2024 · 1d69e1d · 1d69e1d
2 parents 1745b8e + 189af9b
commit 1d69e1d
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/...odernizer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/github/GHService.java b/...odernizer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/github/GHService.java
@@ -135,11 +135,12 @@ private void fetchRepository(Path pluginDirectory, String repoName, String plugi
         String uri = "https://github.com/" + config.getGithubOwner() + "/" + repoName + ".git";
         if (!Files.exists(pluginDirectory) || !Files.isDirectory(pluginDirectory)) {
             LOG.debug("Cloning {}", pluginName);
-            Git.cloneRepository()
+            try (Git git = Git.cloneRepository()
                     .setURI(uri)
                     .setDirectory(pluginDirectory.toFile())
-                    .call();
-            LOG.debug("Cloned successfully from {}", uri);
+                    .call()) {
+                LOG.debug("Cloned successfully from {}", uri);
+            }
         } else {
             // TODO: Cleanup and fetch latest changes. Also ensure on the main branch
         }