Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add declarative recipes using supported yaml OpenRewrite format #131

Merged

Conversation

jonesbusy
Copy link
Collaborator

@jonesbusy jonesbusy commented Jul 28, 2024

Should fix #58

Convert all to declarative recipes and look for recipes on the core artifact (was missing the dependency on jenkins-rewrite)

Automated tests and interactive tests

Use Recipe model and prefix RECIPE_FQDN_PREFIX to keep short name of recipe. Ensure we are using the same openrewrite format and attribute

Using the openrewrite org.openrewrite.config.YamlResourceLoader

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jul 28, 2024
@jonesbusy
Copy link
Collaborator Author

Do not review yet, need to be rebased when checkstyle/spotless if merged

@jonesbusy jonesbusy changed the title Add declarative recipe for ExtractMetadata Add declarative recipes using supported yaml OpenRewrite format Jul 28, 2024
@jonesbusy jonesbusy force-pushed the feature/convert-declarative-recipe branch 8 times, most recently from ad096e9 to 53da397 Compare July 28, 2024 15:18
@jonesbusy jonesbusy marked this pull request as ready for review July 28, 2024 15:19
@jonesbusy jonesbusy requested a review from a team as a code owner July 28, 2024 15:19
@jonesbusy jonesbusy force-pushed the feature/convert-declarative-recipe branch from 53da397 to c07d826 Compare July 28, 2024 15:23
@jonesbusy
Copy link
Collaborator Author

Ready for review

Copy link
Contributor

@sridamul sridamul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonesbusy jonesbusy merged commit c2e0121 into jenkins-infra:main Jul 28, 2024
13 checks passed
@jonesbusy jonesbusy deleted the feature/convert-declarative-recipe branch July 30, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dealing with recipes that requires configuration parameters
2 participants