Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pointless message for slf4j #168

Merged

Conversation

jonesbusy
Copy link
Collaborator

Seems recent upgrade of slf4j (Maybe #164) started to print message when tool is starting

SLF4J(I): Connected with provider of type [ch.qos.logback.classic.spi.LogbackServiceProvider]

This is not useful at all, we know that we are using logback as logger implementation

Removing this message

See https://stackoverflow.com/questions/78063648/how-to-stop-slf4j-printing-a-pointless-information-message-at-startup

Testing done

Ensuring the message disapear when running the tool after setting the system property

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

…h.qos.logback.classic.spi.LogbackServiceProvider]
@jonesbusy jonesbusy added the chore label Aug 9, 2024
@jonesbusy jonesbusy requested a review from a team as a code owner August 9, 2024 06:53
@jonesbusy
Copy link
Collaborator Author

See also qos-ch/slf4j#422

@jonesbusy jonesbusy merged commit 1fa719a into jenkins-infra:main Aug 9, 2024
14 checks passed
@jonesbusy jonesbusy deleted the feature/remove-pointless-message branch August 9, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants