Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isForked() to check only the current github owner #181

Conversation

jonesbusy
Copy link
Collaborator

The implementation was too permission to do an ||

It can cause issue if the repo is already forked on personal account but non on your organisation.

The isForked() could return true which cause issue later when getting the repo from organisation.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy added the bug For changelog: Minor bug. Will be listed after features label Aug 13, 2024
@jonesbusy jonesbusy requested a review from a team as a code owner August 13, 2024 07:51
@jonesbusy jonesbusy merged commit 105ac1f into jenkins-infra:main Aug 13, 2024
14 checks passed
@jonesbusy jonesbusy deleted the bugfix/is-forked-should-consider-only-current-owner branch August 13, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants