Improve caching mechanism #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonesbusy
reviewed
Aug 17, 2024
...-modernizer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/impl/CacheManager.java
Outdated
Show resolved
Hide resolved
jonesbusy
reviewed
Aug 17, 2024
...-modernizer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/impl/CacheManager.java
Outdated
Show resolved
Hide resolved
jonesbusy
reviewed
Aug 17, 2024
...-modernizer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/impl/CacheManager.java
Outdated
Show resolved
Hide resolved
jonesbusy
reviewed
Aug 17, 2024
| * @param cacheKey key to lookup, i.e. update-center | ||
| * @return the cached json object as a string or null | ||
| */ | ||
| public String retrieveFromCache(String cacheKey) { |
There was a problem hiding this comment.
I would introduce a simple POJO
Suggested change
| public String retrieveFromCache(String cacheKey) { | |
| public CacheItem retrieveFromCache(String cacheKey) { | |
| `` |
There was a problem hiding this comment.
Also a bit more context. If we add a class CacheItem (abstract or not) it means that we can cache entities like Plugin or other content
jonesbusy
reviewed
Aug 17, 2024
| @@ -30,4 +44,62 @@ void createCache() { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| public void addToCache(String cacheKey, String value) { | |||
There was a problem hiding this comment.
Suggested change
| public void addToCache(String cacheKey, String value) { | |
| public void addToCache(String cacheKey, CacheItem item) { |
jonesbusy
reviewed
Aug 17, 2024
| private final Path cache; | ||
| private final Clock clock; |
There was a problem hiding this comment.
Why is it a member ? My feeling is that a simple static constant would fit
There was a problem hiding this comment.
Hey @jonesbusy Doesn't a member useful for testing purposes?
jonesbusy
reviewed
Aug 17, 2024
...-modernizer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/impl/CacheManager.java
Outdated
Show resolved
Hide resolved
jonesbusy
requested changes
Aug 17, 2024
…dernizer/core/impl/CacheManager.java Co-authored-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
iamrajiv
approved these changes
Aug 17, 2024
|
Let me know if you prefer to merge as is and improve later. Remaining point are not blocking for me |
|
We can merge it |
jonesbusy
approved these changes
Aug 17, 2024
jonesbusy
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #176
Testing done
interactive tests + unit tests
Submitter checklist