Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify with jdk that used in compile phase #187

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

sridamul
Copy link
Contributor

Right now, the plugin is verified with JDK 17 even though a plugin with JDK 8 or JDK 11 supported is compiled.
This PR verifies with JDK as used in compile phase.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@sridamul sridamul requested a review from a team as a code owner August 18, 2024 06:37
@jonesbusy
Copy link
Collaborator

I think this will not work if we fully refresh a plugin. It will not be compatible with Java 8 but only 11 and even soon Java 17 due to recent core minimum requirement. And a number of plugin that will bundle dependencies requiring Java 17

I think we

  • EIther rely on the metadata (but we miss some logic related to minimum JDK build)
  • Use the same logic but downgrading the verify until we find a correct one

Probably the 2nd is more quick to implement for now

  • Compile with max JDK
  • If it fail downgrade it until it works

@jonesbusy jonesbusy merged commit bbab6c9 into jenkins-infra:main Aug 18, 2024
14 checks passed
@sridamul sridamul deleted the verify-jdk branch August 18, 2024 07:52
@jonesbusy jonesbusy added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants