Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some entities to CacheEntry to be saved and cached to filesystem and use it's API for PluginMetada #197

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

jonesbusy
Copy link
Collaborator

@jonesbusy jonesbusy commented Aug 19, 2024

It's a quiete large PR sorry but was difficult to split.

This basically add the CacheEntry object into the game. It's used by the CacheManager

Testing done

Rely on automated tests (needed to adapt some of them due to changes of public API)

Tested the metadata is moved from a virtual target/plugin-metadata into the tool cache (~/.cache/). This was necessary because target folder are empty when maven clean run or on git clean operation.

plugin-metadata

This PR will also allow some more caching like the Plugin entity if we need to

This PR also add some JSON utility instead of create GSON object everywhere. I'm also not 100% happy with GSON. Perhaps we should move to Jackson this utility class that give more flexibility using annotation

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Aug 19, 2024
@jonesbusy jonesbusy requested a review from a team as a code owner August 19, 2024 15:29
@jonesbusy jonesbusy merged commit 86c3da7 into jenkins-infra:main Aug 19, 2024
14 checks passed
@jonesbusy jonesbusy deleted the feature/serialization-utils branch August 19, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants