Move some entities to CacheEntry to be saved and cached to filesystem and use it's API for PluginMetada #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a quiete large PR sorry but was difficult to split.
This basically add the
CacheEntry
object into the game. It's used by theCacheManager
Testing done
Rely on automated tests (needed to adapt some of them due to changes of public API)
Tested the metadata is moved from a virtual target/plugin-metadata into the tool cache (
~/.cache/
). This was necessary because target folder are empty when maven clean run or on git clean operation.This PR will also allow some more caching like the
Plugin
entity if we need toThis PR also add some JSON utility instead of create GSON object everywhere. I'm also not 100% happy with GSON. Perhaps we should move to Jackson this utility class that give more flexibility using annotation
Submitter checklist