Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JDK from metadata if possible #216

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

jonesbusy
Copy link
Collaborator

This also simplify the PluginModernizer flow

  • We don't compile the plugin if we don't have metadata
  • Create local metadata or get them from cache if present
  • We run the recipe
  • We verify the plugin (including tests)

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Aug 22, 2024
@jonesbusy jonesbusy requested a review from a team as a code owner August 22, 2024 13:57
@jonesbusy jonesbusy changed the title Use JDK from metadata if possilbe Use JDK from metadata if possible Aug 22, 2024
PluginMetadata metadata = plugin.getMetadata();
JDK jdk;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was way too complicated for so little benefit

@jonesbusy jonesbusy force-pushed the feature/use-jdk-from branch from 1bc6d6d to f55beb1 Compare August 22, 2024 13:59
@jonesbusy jonesbusy merged commit 53f22f8 into jenkins-infra:main Aug 22, 2024
14 checks passed
@jonesbusy jonesbusy deleted the feature/use-jdk-from branch August 22, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants