Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JGit 7 #221

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

jonesbusy
Copy link
Collaborator

Fix #107

JGit doesn't providing signing with SSH, but at least it doesn't fail because the constant doesn't exists

No breaking changes expected. JGit 7 require now JDK 17 but our tool is already built with Java 17

I would suggest we open a small improvement to setup GPG signing if requested by the user

And my .gitconfig

[user]
	signingkey = /home/valentin/.ssh/id_ed25519
[gpg]
	format = ssh
[commit]
	gpgsign = true

Testing done

Tested by opening this pr jenkinsci/asm-api-plugin#39

Some tests are already prepared for the git plugin

jenkinsci/git-client-plugin#1170
jenkinsci/git-client-plugin#1172

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy requested a review from a team as a code owner August 24, 2024 05:27
Copy link
Collaborator

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonesbusy jonesbusy merged commit 9f24c66 into jenkins-infra:main Aug 24, 2024
14 checks passed
@jonesbusy jonesbusy deleted the feature/upgrade-jgit branch August 24, 2024 06:30
@jonesbusy jonesbusy added bug For changelog: Minor bug. Will be listed after features dependencies Pull requests that update a dependency file labels Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use gpg.format=ssh when set globally on git config
2 participants