Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save precondition errors on metadata #222

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

jonesbusy
Copy link
Collaborator

Allow very outdated plugin that we cannot even build with recent Maven or Java 8 to have their metadata saved

Testing done

Tested with outdated plugin

Examples

{"errors":["MAVEN_REPOSITORIES_HTTP","MISSING_RELATIVE_PATH","OLDER_JAVA_VERSION"],"key":"plugin-metadata","path":"adaptive-disconnector"}
{"errors":["OLDER_JAVA_VERSION"],"key":"plugin-metadata","path":"vagrant"}

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy requested a review from a team as a code owner August 24, 2024 08:18
@jonesbusy jonesbusy force-pushed the feature/static-flag branch from 54cd7ee to 4057cc7 Compare August 25, 2024 08:08
@jonesbusy
Copy link
Collaborator Author

Ready for review. I've rebased the PR and fixed conflicts

@jonesbusy jonesbusy force-pushed the feature/static-flag branch from 4057cc7 to b816315 Compare August 25, 2024 08:10
@jonesbusy jonesbusy requested a review from sridamul August 25, 2024 08:11
Copy link
Contributor

@sridamul sridamul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much :-)

@jonesbusy jonesbusy merged commit a22c6f1 into jenkins-infra:main Aug 25, 2024
14 checks passed
@jonesbusy jonesbusy deleted the feature/static-flag branch August 25, 2024 08:19
@jonesbusy jonesbusy added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants