Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dryRun cli Option #25

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Add dryRun cli Option #25

merged 2 commits into from
Jun 22, 2024

Conversation

sridamul
Copy link
Contributor

closes #23 - Added new cli option to enable dry run without making any changes

Testing done

Manual testing done.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@@ -31,6 +31,9 @@ public static void main(final String[] args) {
@Option(names = {"-r", "--recipes"}, required = true, description = "List of Recipes to be applied.", split = ",", parameterConsumer = CommaSeparatedParameterConsumer.class)
private List<String> recipes;

@Option(names = {"-dr", "--dry-run"}, description = "Perform a dry run without making any changes.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short option of 2 letter looks strange to me. I think some tools like Git use the -n option for dry run

@sridamul sridamul requested a review from jonesbusy June 22, 2024 06:39
@jonesbusy jonesbusy merged commit dd7c776 into jenkins-infra:main Jun 22, 2024
12 checks passed
@sridamul sridamul deleted the add-dryrun branch June 22, 2024 06:48
@jonesbusy jonesbusy added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new command line option - dryRun
2 participants