Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused config and override maven home and cache on CLI #30

Merged

Conversation

jonesbusy
Copy link
Collaborator

I don't think we need to change the mavenRewritePluginVersion at runtime. Can be just a constant on the Settings

But passing the --maven-home sounds more useful on environment that doesn't declare (M2_HOME or MAVEN_HOME)

Also use Pathinstead of using String for paths

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy requested a review from sridamul June 22, 2024 09:18
@jonesbusy jonesbusy force-pushed the feature/remove-unused-settings branch from a0f7207 to ce6e6d2 Compare June 22, 2024 09:26
@jonesbusy jonesbusy marked this pull request as draft June 22, 2024 09:31
@jonesbusy
Copy link
Collaborator Author

Draft need to fix tests

@jonesbusy jonesbusy force-pushed the feature/remove-unused-settings branch from f5a6b28 to 1d85a7e Compare June 22, 2024 10:54
@jonesbusy jonesbusy marked this pull request as ready for review June 22, 2024 10:57
@jonesbusy
Copy link
Collaborator Author

This is ready for review. The last commit also ensure to have a predictable version of maven when running integration tests (in the future) and not rely on environment but surefire env vars

Copy link
Contributor

@sridamul sridamul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jonesbusy jonesbusy merged commit 5aa96c7 into jenkins-infra:main Jun 22, 2024
12 checks passed
@jonesbusy jonesbusy deleted the feature/remove-unused-settings branch June 22, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants