Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (empty) function to remediate a precondition error of a plugin #310

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

jonesbusy
Copy link
Collaborator

Relate to https://github.com/jenkinsci/plugin-modernizer-tool/pull/307/files

But without using any transformation

@gounthar Perpaps you can "cherry-pick" code of the PomModifier using of each precondition error remediate function ?

For the moment we don't have tests for the PluginModernizer class but I've tested the function is called with the vagrant plugin for example. Right now all function return false because nothing is done. I left TODOs in the code

remediation

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Oct 9, 2024
@jonesbusy jonesbusy requested a review from a team as a code owner October 9, 2024 05:51
Copy link
Collaborator

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will try to base my work on this. 👍

@jonesbusy jonesbusy merged commit 76c6b20 into jenkins-infra:main Oct 9, 2024
15 checks passed
@jonesbusy jonesbusy deleted the feature/remediation branch October 9, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants