fix(jdk7): Remove comments associated with deleted properties in pom.xml #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #35 Enhance the `removeOffendingProperties` method in `PomModifier.java` to remove comments associated with deleted properties. * Identify comments directly above the properties `jenkins-test-harness.version` and `java.level` and remove them along with the properties. * Update unit tests in `PomModifierTest.java` to verify the removal of comments associated with deleted properties. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/gounthar/plugin-modernizer-tool/issues/35?shareId=XXXX-XXXX-XXXX-XXXX).
jonesbusy
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the
removeOffendingPropertiesmethod inPomModifier.javato remove comments associated with deleted properties.jenkins-test-harness.versionandjava.leveland remove them along with the properties.PomModifierTest.javato verify the removal of comments associated with deleted properties.Testing done
mvn installSubmitter checklist
Link to relevant issues in GitHub or JiraLink to relevant pull requests, esp. upstream and downstream changes