feat(recipes): Add ModernizeJenkinsfile Recipe and UpgradeNextMajorParentVersion Dependency #336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two key enhancements to our recipe collection:
org.openrewrite.jenkins.ModernizeJenkinsfile
into a new modernizer recipe calledAddOrModernizeJenkinsFile
.UpgradeNextMajorParentVersion
as a dependency for the new recipe.Rationale for Dependency
The inclusion of
UpgradeNextMajorParentVersion
as a dependency is based onModernizeJenkinsfile
's latest version, which produces a Jenkinsfile that:This dependency ensures our modernization efforts align with current testing practices across different environments.
Testing Performed
To verify the functionality of the new recipe, the following command was executed:
rm -fr ~/.cache/jenkins-plugin-modernizer-cli/vagrant/ && java -jar plugin-modernizer-cli/target/jenkins-plugin-modernizer-999999-SNAPSHOT.jar --plugins vagrant --recipes MinimalBuildJava8,AddOrModernizeJenkinsFile --debug
This test resulted in the creation of a pull request: jenkinsci/vagrant-plugin#13.
Submitter checklist
Link to relevant issues in GitHub or JiraLink to relevant pull requests, esp. upstream and downstream changes