Check Jenkinsfile presence #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gounthar
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Thank you, Sridhar.
I have a small suggestion: it would be helpful if we could keep the pull requests (PRs) "atomic", focusing on one goal at a time.
For instance, you removed a dependency in the pom file. While this is a valuable change, it could have been submitted as a separate PR later.
This approach helps us maintain a clearer history and makes reviews more straightforward.
|
Reverted back unrelated changes from the PR. Thanks @gounthar. |
jonesbusy
approved these changes
Jun 24, 2024
jonesbusy
approved these changes
Jun 24, 2024
|
Thanks a lot! 🙏 |
jonesbusy
added
the
enhancement
jonesbusy
pushed a commit
that referenced
this pull request
Oct 18, 2024
Fixes #43 Implement the remediation function for `MAVEN_REPOSITORIES_HTTP` to replace 'http' with 'https' in repository URLs. * Modify `plugin-modernizer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/model/PreconditionError.java` to include the remediation function that uses `PomModifier` to replace 'http' with 'https' in repository URLs. * Add a method `replaceHttpWithHttps` in `plugin-modernizer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/utils/PomModifier.java` to replace 'http' with 'https' in repository URLs. * Add tests in `plugin-modernizer-core/src/test/java/io/jenkins/tools/pluginmodernizer/core/extractor/MetadataCollectorTest.java` to verify the functionality of the remediation function for `MAVEN_REPOSITORIES_HTTP`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/gounthar/plugin-modernizer-tool/issues/43?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #41
Updates...
Now we are able to check the presence of Jenkinsfile in a plugin directory. Right now, the execution of this recipe stores the metadata locally in the target directory in JSON format. As suggested by @gounthar in this comment we can store the result in external sources in the following PR after discussions.
Testing done
Submitter checklist