Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API plugin and condition for recipes #485

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

jonesbusy
Copy link
Collaborator

At the end I don't think we need a custom solution for condition

We can easily implement a search recipe (that read or own metadata for example) and use it as conditional for recipes

Fix #320

Possible fix of #476

Testing done

Automated tests and tested the result of the pom for new recipes

diff

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • [] Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy marked this pull request as ready for review December 19, 2024 05:56
@jonesbusy jonesbusy force-pushed the feature/api-conditions branch from dd8bb5c to 012dc75 Compare December 19, 2024 06:23
@jonesbusy jonesbusy force-pushed the feature/api-conditions branch from 012dc75 to 68d7cd2 Compare December 19, 2024 07:37
@jonesbusy jonesbusy marked this pull request as draft December 19, 2024 07:37
@jonesbusy
Copy link
Collaborator Author

Putting in draft to fix tests and cleanup log files

@jonesbusy jonesbusy force-pushed the feature/api-conditions branch 2 times, most recently from 7bdaa12 to 986bace Compare December 19, 2024 08:20
@jonesbusy jonesbusy force-pushed the feature/api-conditions branch from 986bace to 8cff607 Compare December 19, 2024 13:51
@jonesbusy jonesbusy marked this pull request as ready for review December 19, 2024 13:59
@jonesbusy
Copy link
Collaborator Author

All green. Was not flaky test but due to the "logs" folder empty on my environment and was not created by the test if not present

@jonesbusy jonesbusy merged commit c8377c9 into jenkins-infra:main Dec 19, 2024
15 checks passed
@jonesbusy jonesbusy deleted the feature/api-conditions branch December 19, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditional recipes
2 participants