Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Commit with CLI parsing #5

Merged
merged 2 commits into from
Jun 2, 2024
Merged

Initial Commit with CLI parsing #5

merged 2 commits into from
Jun 2, 2024

Conversation

sridamul
Copy link
Contributor

@sridamul sridamul commented Jun 2, 2024

In this PR,

  • I set up the project
  • Implemented the CLI module functions (not all)
  • Unit test coverage for CLI module classes
  • Integrated spotbugs
  • Used maven assembly plugin to build jar with dependencies

cc: @berviantoleo, @iamrajiv, @jonesbusy, @gounthar

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

gh-integration/pom.xml Outdated Show resolved Hide resolved
core/pom.xml Outdated
<parent>
<groupId>io.jenkins.plugin-modernizer</groupId>
<artifactId>plugin-modernizer-parent-pom</artifactId>
<version>${revision}${changelist}</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are using CD also for the tool (Which I like very much) I think we are missing some files like https://www.jenkins.io/doc/developer/publishing/releasing-cd/#update-maven-pom-and-config

Also incrementals must be enabled (I would suggest to check some plugin with CD enabled)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take a look into it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! @jonesbusy I have enabled incrementals and added Dependabot. Will configure others later.

core/pom.xml Outdated Show resolved Hide resolved
@jonesbusy jonesbusy merged commit 14e5864 into jenkins-infra:main Jun 2, 2024
@sridamul sridamul deleted the dev branch June 2, 2024 13:42
@jonesbusy jonesbusy added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants