Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for core module classes #61

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Add unit tests for core module classes #61

merged 2 commits into from
Jul 5, 2024

Conversation

sridamul
Copy link
Contributor

@sridamul sridamul commented Jul 1, 2024

Added unit tests for Config class

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@sridamul
Copy link
Contributor Author

sridamul commented Jul 1, 2024

This will have conflict with PR #59. Will resolve after merging #59.

@sridamul sridamul marked this pull request as ready for review July 5, 2024 12:50
@sridamul sridamul requested a review from a team as a code owner July 5, 2024 12:50
@sridamul
Copy link
Contributor Author

sridamul commented Jul 5, 2024

Hey @gounthar, I think we can merge this. I will create separate PRs for further test coverage. Thanks!

@gounthar gounthar merged commit c4299b1 into jenkins-infra:main Jul 5, 2024
13 checks passed
@sridamul sridamul deleted the increase-test-coverage-core branch July 5, 2024 19:38
@jonesbusy jonesbusy added the tests This PR adds/removes/updates test cases label Jul 12, 2024
@gounthar gounthar mentioned this pull request Dec 19, 2024
Merged
6 tasks
jonesbusy pushed a commit that referenced this pull request Dec 20, 2024
@gounthar
Fix build process on aarch64 machines
d02e221 
Fixes #61

Update `JdkFetcher.java` to support aarch64 architecture.

* Modify `buildJDKFileName` method to include architecture in the file name.
* Add `getArchitecture` method to determine the system architecture.
* Update `CommandLineITCase.java` to handle architecture-specific JDK paths.
* Add `testBuildMetadataOnAarch64` method to verify the build process on aarch64 architecture.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/gounthar/plugin-modernizer-tool/issues/61?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berviantoleo berviantoleo berviantoleo approved these changes

@jonesbusy jonesbusy jonesbusy approved these changes

@gounthar gounthar gounthar approved these changes

Assignees
No one assigned
Labels
tests This PR adds/removes/updates test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sridamul @gounthar @jonesbusy @berviantoleo