Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maven version validation #64

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Maven version validation #64

merged 1 commit into from
Jul 7, 2024

Conversation

jonesbusy
Copy link
Collaborator

@jonesbusy jonesbusy commented Jul 7, 2024 •
edited
Loading

Maven is necessary to run the recipes via the CLI. This PR ensure we run it againts a recent version of maven

Testing done

Automated tests and tested via changing the minimum required version and ensure the version is validated correctly

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jul 7, 2024
@jonesbusy jonesbusy requested a review from a team as a code owner July 7, 2024 11:02
@jonesbusy jonesbusy merged commit 47a0969 into jenkins-infra:main Jul 7, 2024
13 checks passed
@jonesbusy jonesbusy mentioned this pull request Jul 7, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrajiv iamrajiv iamrajiv approved these changes

Assignees
No one assigned
Labels
enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonesbusy @iamrajiv