Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI/CD #8

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Conversation

jonesbusy
Copy link
Collaborator

@jonesbusy jonesbusy commented Jun 2, 2024

Setup CI/CD

Also I suggest to disable Actions until we reach a usable version of the tool (or we will create a lot of release for nothing).

But at least the CI will be ready and CD ready to be turn on in some weeks/month

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@@ -13,7 +13,8 @@

<groupId>io.jenkins.plugin-modernizer</groupId>
<artifactId>plugin-modernizer-parent-pom</artifactId>
<version>${revision}${changelist}</version>
Copy link
Contributor

@sridamul sridamul Jun 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the version shown when the jar is executed with -V option

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maven inherit the version.

Confirmed filtering works with

java -jar plugin-modernizer-cli/target/jenkins-plugin-modernizer-6.ve1a_9d7f37c6f.jar --version
6.ve1a_9d7f37c6f

@NotMyFault
Copy link
Member

This require to create a job on ci.jenkins.io similar to ci.jenkins.io/job/Tools/job/plugin-installation-manager-tool

I've added a job for you, given this causes a reiteration over all repositories, I prefer to do that on the weekend :P

@jonesbusy
Copy link
Collaborator Author

This require to create a job on ci.jenkins.io similar to ci.jenkins.io/job/Tools/job/plugin-installation-manager-tool

I've added a job for you, given this causes a reiteration over all repositories, I prefer to do that on the weekend :P

Thanks a lot!

@jonesbusy jonesbusy merged commit dd8e342 into jenkins-infra:main Jun 2, 2024
12 checks passed
@jonesbusy jonesbusy deleted the feature/setup-ci-cd branch June 2, 2024 15:17
@jonesbusy jonesbusy added the chore label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants