-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New option to parse plugins.txt file #86
Conversation
@@ -0,0 +1,3 @@ | |||
jobcacher-plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the repo name, not the plugin name.
I think we are wrongly using pluginName with -plugin suffix but in fact it's the repo name.
Perhaps we should clarifiy this in the tool before this PR.
Passing the plugin short name and getting the SCM url from the plugin center ? Or just ammending the -plugin
to create the repo ? But I'm not sure it will work 100% of time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better safe than sorry, we should make it super clear in the documentation, the comments, and the code. 👍
Thanks for catching that early!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarifiy usage of pluginName vs repo name
I think I misunderstood in the previous conversation. I thought it would easier to look up the repo name instead of plugin name from the UC.
I think it is better to get SCM link from uc |
Will create a PR to fetch SCM url from UC by passing the plugin short name (instead of passing the repo name in plugin option) |
Closes #77
Added new option to parse plugins.txt file
Testing done
Written unit tests
Submitter checklist