Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option to parse plugins.txt file #86

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

sridamul
Copy link
Contributor

@sridamul sridamul commented Jul 15, 2024

Closes #77
Added new option to parse plugins.txt file

Testing done

Written unit tests

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@sridamul sridamul requested a review from a team as a code owner July 15, 2024 13:00
@@ -0,0 +1,3 @@
jobcacher-plugin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the repo name, not the plugin name.

I think we are wrongly using pluginName with -plugin suffix but in fact it's the repo name.

Perhaps we should clarifiy this in the tool before this PR.

Passing the plugin short name and getting the SCM url from the plugin center ? Or just ammending the -plugin to create the repo ? But I'm not sure it will work 100% of time

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better safe than sorry, we should make it super clear in the documentation, the comments, and the code. 👍
Thanks for catching that early!

Copy link
Collaborator

@jonesbusy jonesbusy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarifiy usage of pluginName vs repo name

@sridamul
Copy link
Contributor Author

sridamul commented Jul 15, 2024

I think I misunderstood in the previous conversation. I thought it would easier to look up the repo name instead of plugin name from the UC.

Passing the plugin short name and getting the SCM url from the plugin center ? Or just ammending the -plugin to create the repo ? But I'm not sure it will work 100% of time

I think it is better to get SCM link from uc

@sridamul
Copy link
Contributor Author

sridamul commented Jul 15, 2024

Will create a PR to fetch SCM url from UC by passing the plugin short name (instead of passing the repo name in plugin option)

@sridamul sridamul requested a review from jonesbusy July 16, 2024 07:35
@sridamul sridamul requested a review from berviantoleo July 16, 2024 10:01
@jonesbusy jonesbusy merged commit d9bb2ff into jenkins-infra:main Jul 16, 2024
13 checks passed
@sridamul sridamul deleted the plugins-file-option branch July 16, 2024 12:37
@jonesbusy jonesbusy added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to pass plugin via a plugin.txt
5 participants