Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding froblesmartin (myself) as developer in EC2 plugin #1652

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Adding froblesmartin (myself) as developer in EC2 plugin #1652

merged 1 commit into from
Aug 26, 2020

Conversation

froblesmartin
Copy link
Contributor

@froblesmartin froblesmartin commented Aug 25, 2020

Description

I am requesting to be added as maintainer of the EC2 plugin as it is up for adoption as said by @jvz in this PR: jenkinsci/ec2-plugin#445.

Plugin GitHub URL: https://github.com/jenkinsci/ec2-plugin

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @daniel-beck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@froblesmartin froblesmartin requested a review from a team as a code owner August 25, 2020 16:43
@jvz
Copy link
Contributor

jvz commented Aug 25, 2020

@MRamonLeon This alright with you too?

@froblesmartin
Copy link
Contributor Author

Jenkins failed due to not finding me on the Artifactory list of users, but I did log in when filling this PR 🤔 How can I rebuild it?

@MarkEWaite
Copy link
Contributor

Jenkins failed due to not finding me on the Artifactory list of users, but I did log in when filling this PR 🤔 How can I rebuild it?

I saw your comment and restarted the job. In the future, we'll have the ability to restart a job by placing a GitHub comment or something similar. Not there yet

Copy link
Contributor

@jvz jvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool with me. @fcojfernandez @MRamonLeon ?

@slide slide merged commit 9394c7e into jenkins-infra:master Aug 26, 2020
@slide
Copy link
Contributor

slide commented Aug 26, 2020

Please accept the invitation to join the jenkinsci org on GitHub. You should have received an email about it.

@froblesmartin froblesmartin deleted the patch-1 branch August 26, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants