Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use artifact caching proxy for acceptance-test-harness #1279

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Jul 12, 2023

This PR activates the use of artifact caching proxy for this repository.

Closes #963

Ref: jenkins-infra/helpdesk#3481 (comment) & jenkins-infra/helpdesk#2752

Testing done

Successfully ran a replay with the no-tranfer-progress option removed from run.sh to check the use of the artifact caching proxy: https://ci.jenkins.io/job/Core/job/acceptance-test-harness/job/PR-1279/4/

Submitter checklist

@lemeurherve lemeurherve force-pushed the test-acp branch 2 times, most recently from 3f3a88c to dfe48c0 Compare July 12, 2023 13:35
@lemeurherve lemeurherve changed the title Test artifact-caching-proxy Use artifact caching proxy for acceptance-test-harness Jul 12, 2023
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional feedback for your consideration: Might be desirable to do a few more consecutive test runs (e.g., 3-5 runs) to truly convince ourselves that we are not adding any (new) flakiness? (Note: This repository is already flaky for non-artifact-caching proxy reasons; the only concern is not to make it more flaky, so a reference set of 3-5 test runs without this PR might be needed for a fair apples-to-apples comparison.)

@basil basil requested review from NotMyFault and timja July 12, 2023 20:01
@lemeurherve
Copy link
Member Author

@basil thanks for the feedback! In addition to the initial run without -ntp mvn argument to confirm the use of ACP, I ran 3 consecutive builds from 71ade07, then 2 builds in parallel (same commit), removing disableConcurrentBuilds from these last replays to push a little bit more the load on ACP, with success:

image

This repository is already flaky for non-artifact-caching proxy reasons; the only concern is not to make it more flaky, a reference set of 3-5 test runs without this PR might be needed

As all test runs from this PR finished without issue, do you think running a reference set of test runs is still desirable or could the existing ones be considered as conclusive?

@timja timja added the chore label Jul 13, 2023
@timja timja merged commit 9f64fd9 into jenkinsci:master Jul 13, 2023
@lemeurherve lemeurherve deleted the test-acp branch July 13, 2023 13:39
@basil
Copy link
Member

basil commented Jul 13, 2023

I think we can consider the existing runs as conclusive. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Jenkins project mirrors / caches
3 participants