- add test data to clarify that % encoding in file is also getting tr…

…anslated
jenkinsci · Nov 4, 2024 · a7ff4b5 · a7ff4b5
1 parent a78a4a0
commit a7ff4b5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/main/java/edu/hm/hafner/analysis/parser/violations/SarifAdapter.java b/src/main/java/edu/hm/hafner/analysis/parser/violations/SarifAdapter.java
@@ -5,6 +5,8 @@
 import se.bjurr.violations.lib.parsers.SarifParser;
 
 import java.net.URI;
+import java.net.URISyntaxException;
+import java.nio.file.InvalidPathException;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 
@@ -36,7 +38,7 @@ String convertFileUriSchemeToPath(final String fileName) {
             Path path = Paths.get(new URI(fileName));
             return path.toString();
         } 
-        catch (Exception e) 
+        catch (URISyntaxException | InvalidPathException e)
         {
             // ignore
         }

diff --git a/src/test/java/edu/hm/hafner/analysis/parser/violations/SarifAdapterTest.java b/src/test/java/edu/hm/hafner/analysis/parser/violations/SarifAdapterTest.java
@@ -61,7 +61,7 @@ void handleFilePathsInFileURIschemeFormat() {
                     .hasSeverity(Severity.WARNING_NORMAL)
                     .hasLineStart(5)
                     .hasLineEnd(5)
-                    .hasFileName("C:/my/workspace/project/whatever/path.cs");
+                    .hasFileName("C:/my/workspace/project/whatever/€path.cs");
         }
     }
 

diff --git a/src/test/resources/edu/hm/hafner/analysis/parser/violations/filePathInFileUriScheme.sarif b/src/test/resources/edu/hm/hafner/analysis/parser/violations/filePathInFileUriScheme.sarif
@@ -15,7 +15,7 @@
               {
                 "physicalLocation": {
                   "artifactLocation": {
-                    "uri": "whatever/path.cs",
+                    "uri": "whatever/%E2%82%ACpath.cs",
                     "uriBaseId": "solutionDir",
                     "index": 0
                   },
@@ -196,7 +196,7 @@
         "artifacts": [
           {
             "location": {
-              "uri": "whatever/path.cs",
+              "uri": "whatever/%E2%82%ACpath.cs",
               "uriBaseId": "solutionDir"
             }
           },