Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins 56333: pc-lint: categorize errors as errors and not warning (high) #129

Merged
merged 3 commits into from
Mar 25, 2019

Conversation

DaMutz
Copy link

@DaMutz DaMutz commented Mar 23, 2019

No description provided.

@codecov
Copy link

codecov bot commented Mar 23, 2019

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #129   +/-   ##
=========================================
  Coverage     87.81%   87.81%           
  Complexity     1211     1211           
=========================================
  Files           157      157           
  Lines          3857     3857           
  Branches        425      425           
=========================================
  Hits           3387     3387           
  Misses          312      312           
  Partials        158      158
Impacted Files Coverage Δ Complexity Δ
...a/edu/hm/hafner/analysis/parser/MsBuildParser.java 80.7% <100%> (ø) 19 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d30763...8ba2e35. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 23, 2019

Codecov Report

Merging #129 into master will decrease coverage by 0.01%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #129      +/-   ##
============================================
- Coverage     87.85%   87.84%   -0.02%     
+ Complexity     1211     1207       -4     
============================================
  Files           156      156              
  Lines          3855     3850       -5     
  Branches        425      424       -1     
============================================
- Hits           3387     3382       -5     
- Misses          310      311       +1     
+ Partials        158      157       -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/edu/hm/hafner/analysis/Severity.java 96.29% <100%> (ø) 26 <0> (ø) ⬇️
...a/edu/hm/hafner/analysis/parser/MsBuildParser.java 78.84% <50%> (-1.86%) 15 <0> (-4)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e19f2...ed813ba. Read the comment docs.

@uhafner
Copy link
Member

uhafner commented Mar 25, 2019

Would it make sense to add "note" to Severity.guessFromString as well?

@DaMutz
Copy link
Author

DaMutz commented Mar 25, 2019

Would it make sense to add "note" to Severity.guessFromString as well?

yes, it looks good with the 'note'. In general there are not many test cases for this parser so the only possibility to improve it to get more data or wait for issues in jenkins.

@uhafner uhafner merged commit b4d0305 into jenkinsci:master Mar 25, 2019
@uhafner
Copy link
Member

uhafner commented Mar 25, 2019

Thanks!

@DaMutz DaMutz deleted the JENKINS-56333 branch March 26, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants