JENKINS-52477 - XML Parsers should use report encoding given in XML file #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructor - JENKINS-52477
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
============================================
+ Coverage 88.11% 88.47% +0.36%
- Complexity 1218 1232 +14
============================================
Files 158 158
Lines 3904 3923 +19
Branches 425 427 +2
============================================
+ Hits 3440 3471 +31
+ Misses 308 295 -13
- Partials 156 157 +1
Continue to review full report at Codecov.
|
uhafner
reviewed
Apr 3, 2019
| private Charset detectCharset(final InputStream inputStream) throws IOException { | ||
| Charset result = null; | ||
|
|
||
| try { |
There was a problem hiding this comment.
Simpler:
try (Reader reader = new InputStreamReader(inputStream)) {
| catch (XMLStreamException e) { | ||
| // Charset couldn't be detected | ||
| } | ||
| inputStream.close(); |
There was a problem hiding this comment.
Can be removed if try-with-resources is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect charset to use from xml header, when not specified in the FileReaderFactory constructor. Added a FileReaderFactory constructor without a charset parameter.