[JENKINS-57365] Fixes false positives for MsBuild #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject name contains the string info/note/warning This change requires a whitespace in front of the strings note, info, warning or fatal error to be recognized as the corresponding warnings. See also: https://issues.jenkins-ci.org/browse/JENKINS-57365
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
========================================
Coverage 88.4% 88.4%
Complexity 1295 1295
========================================
Files 161 161
Lines 4147 4147
Branches 441 441
========================================
Hits 3666 3666
Misses 326 326
Partials 155 155
Continue to review full report at Codecov.
|
uhafner
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes false positives for MsBuild if e.g. a build project name contains the string info/note/warning.
This change requires a whitespace in front of the strings note, info, warning or fatal error to be recognized as the corresponding warnings.
See also: https://issues.jenkins-ci.org/browse/JENKINS-57365