Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep PathUtil inside of sym-linked directories #80

Merged
merged 2 commits into from
Jan 21, 2019

Conversation

jftsunami
Copy link
Contributor

Additionally, this includes the Eclipse metadata that @uhafner and I talked about a few weeks ago. Doesn't match IntellaJ perfectly, but rather close.

Activates for PMD, Checkstyle, and SpotBugs plugins
Best-attempt at matching IntellaJ's source formatting
To avoid possible edge cases, lock down PathUtils to not translate
symbolic links into actual filesystem files when trying to resolve full
paths.
@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #80   +/-   ##
=========================================
  Coverage     86.82%   86.82%           
  Complexity     1152     1152           
=========================================
  Files           157      157           
  Lines          3741     3741           
  Branches        408      408           
=========================================
  Hits           3248     3248           
  Misses          332      332           
  Partials        161      161
Impacted Files Coverage Δ Complexity Δ
src/main/java/edu/hm/hafner/util/PathUtil.java 100% <100%> (ø) 10 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51d134d...ff599df. Read the comment docs.

@uhafner uhafner merged commit 398c9e3 into jenkinsci:master Jan 21, 2019
@jftsunami jftsunami deleted the pathutil-symlink branch May 8, 2019 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants