Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase core baseline #153

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Increase core baseline #153

merged 1 commit into from
Jul 18, 2023

Conversation

basil
Copy link
Member

@basil basil commented Jul 18, 2023

#152 introduced a dependency on an API from Jenkins 2.406/2.410 without adjusting the core baseline accordingly. This PR corrects the problem.

@basil basil added the bug label Jul 18, 2023
@basil basil mentioned this pull request Jul 18, 2023
Merged
gounthar
gounthar approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see that coming.
Thanks a lot for that, Basil. 👍

@gounthar gounthar merged commit 42d2457 into jenkinsci:master Jul 18, 2023
13 checks passed
@basil basil deleted the baseline branch July 18, 2023 15:48
@basil
Copy link
Member Author

basil commented Jul 20, 2023

Thanks! Can this please be released?

@gounthar
Copy link
Contributor

The process ended on my Chromebook, which was unexpected (aarch64 and Android tools mostly don't mix well). 🤔
Hopefully, all went fine on the repo too.

@basil
Copy link
Member Author

basil commented Jul 20, 2023

See https://plugins.jenkins.io/android-emulator/

@gounthar
Copy link
Contributor

Thanks.
It's not showing on GitHub releases pages (yet?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gounthar gounthar gounthar approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basil @gounthar